Hi! Ralph Glasstetter wrote:
>>I'll also take a look into >>adding a checkbox (or similar) for choosing pipe output. > > > I also played a little bit around with that and added an entry > to the muxerlist which uses a configurable command/label form the > settings-file (see the attached patch)... Nah... that's non-obvious. Besides that, you'll want to be able to use all muxers (except the TS muxer, maybe) for authoring. > OK,... with this approach I fixed the muxer type to the internal one which is > not very flexible (= 1. not so nice feature). If you know how to add a > checkbox "Use Output Pipe" one could also select the ffmpeg muxer or even > other output formats... that would be better! > > The specified command line in the settings understands the placeholders > %CHAPTER% and %OUTPUT%... the first one will be replaced by the comma > separated list of chapter time stamps and the later by the file or directory > name given in the dialog. > > Unfortunately this is a FileOpen dialog and so to get a directory for the > dvdauthor output one has to type it manually ( = 2. not so nice feature). Yep. I think it's better to use a custom dialog that also includes a checkbox and another text field for the postprocessing command (sans "|" in front of it). > I also added a check for exists()&isExecutable() of the used command, since > your patch crashed when not finding the pipe script. Unfortunatley this > implies now, that one has to give the command/script with full pathname (= 3. > not so nice feature). Maybe some one knows a solution for checking the $PATH > for a command drom inside dvbcut (analog to the which command)? It's better to add proper error checking and reporting to the pipe code. So far, the function just returns when it cannot fork or open the pipe, and the exit status of the child isn't checked either, so there is no indication at all if the export actually worked. > PS: BTW,... I found a bug concerning the chapterlist, which is also fixed in > this patch! I also can send it separately Michael if you want to include it > before (just 3-4 lines in the end of dvbcut.cpp resp. in > quick_picture_lookup_table()... maybe a left over from the old mechanism, > showing up when START is on picture 0...?). You mean, this one? > } > break; > case EventListItem::chapter: > - if (startpic<=0) > - chapterlist.push_back(outpts); > - else > + if (startpic>=0) > chapterlist.push_back(eli.getpts()-startpts+outpts); > break; > default: -- Michael "Tired" Riepe <[EMAIL PROTECTED]> X-Tired: Each morning I get up I die a little ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ DVBCUT-user mailing list DVBCUT-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dvbcut-user
