Stephen Leake <[EMAIL PROTECTED]> writes: > If we use letters for now, and gradually convert code to use > dvc-diff-ewoc->status, then at some point we can switch to using symbols. > > On the other hand, maybe it's not all that much work to just go > straight to symbols. I guess I'll look at that some more.
I'd say: don't discard the idea of symbol too fast. It would take some time, but save some time in the future ... > Is the list of symbols I suggested a good start? It seems to be, yes. There's also another thing to take care of, which is the type of file (file, directory, symlink). That should be a different field in the ewoc (it's currently also a letter IIRC). >> Indeed, to be general, it should be a list of symbols, because a file >> can, for example, be both modified and renamed. > > Ah. > > If the user edits a file, and then renames it, and then runs > dvc-status, won't it show up as 'missing old-name' and 'unknown new-name'? Depending on whether the user ran "XXX mv old-name new-name" to actually rename the file. In most cases, the backend will actually show two lines M new-name R old-name => new-name But even if we use a singleton 99% of the time, we should not restrict the model to singletons. Using a list is probably not more difficult. -- Matthieu _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
