Stephen Leake <[EMAIL PROTECTED]> writes: > Matthieu Moy <[EMAIL PROTECTED]> writes: > >> Well, perhaps dvc-diff-mode is not the best name for this mode, but >> the idea is that it is a superset of a diff-mode and a status-mode. >> You get a short summary at the top, and a diff below. Since it is >> possible to have a buffer in diff-mode without having the diff at the >> bottom, that mode really suits the need to run "status". > > Hmm. I had not noticed that option. How do I get that?
Just see what bzr-status and baz-status are doing. > Sometimes I find the diff listing useful, but mostly not. If you're talking about the summary at the top of the diff buffer, to me, this is *the* added value of dvc-diff-mode compared to plain diff-mode. If the diff covers multiple files, and doesn't fill in a screen, I still want to know easily which files are touched by the patch. Why do you think "diffstat" is so popular in patch exchanging communities? >> Implementing a new diff-mode, and removing the summary part from the >> diff-mode would be a real loss of functionality IMHO. The summary is >> really the part you want to start with as soon as the diff is more >> than a screen long, and you have the key 'j' to switch from the >> summary to the diff, and vice-versa. > > Actually, I'm implementing a new status-mode, and leaving the current > diff-mode alone. > > I'm using symbols for the file status (instead of letters), and a CL > struct for the ewoc data. So it is easier to understand and edit. That is something we wanted to do for a long time for dvc-diff-mode, but no one took the time to do it. Indeed, the relevant structure to describe the state of a file is a list of symbols (like, '(modified renamed mode-change)). > Perhaps it would make sense to change the current diff-mode to be > more like what I want. Definitely. Doing what you're doing right now, you'll end-up with a new mode, you'll have to write back-ends for it (you may not /yet/ have touched the backends, but one day, you'll need someone to fill-in your ewoc structure for each back-end), and the diff-mode will still be using letters, so you'll have something worst than duplication of code: duplication, with one of the version obsoleted but still without correct replacement. In other words: before implementing a new status-mode, please, identify _problems_ with the current diff-mode, that are not fixable in diff-mode itself. I haven't seen any in this thread yet. Thanks for your work, anyway :-). -- Matthieu _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
