Michael Olson <[EMAIL PROTECTED]> writes:

>   * lisp/dvc-utils.el (dvc-ewoc-delete): Move the compatibility function
>     for ewoc-delete from dvc-emacs.el to here, and rename it
>     dvc-ewoc-delete.  Use it throughout instead of ewoc-delete.  This fixes
>     another XEmacs 21.5 issue.

I don't understand this fix.

Previously, we had in dvc-emacs.el:

(if (not (fboundp 'ewoc-delete))
  (defun ewoc-delete (ewoc &rest nodes)
    ...

Now, we have in dvc-utils.el:

(if (fboundp 'ewoc-delete)
    (defalias 'dvc-ewoc-delete 'ewoc-delete)
  (defun dvc-ewoc-delete (ewoc &rest nodes)
    ...

Why is this better?

It seems to me it is better to use the Emacs name 'ewoc-delete', so
when XEmacs implements ewoc-delete, we don't have to change so much
code.

>   * lisp/dvc-fileinfo.el (dvc-fileinfo-same-status): mapc was being called
>     with only one argument.  Fix this, and change it to a dolist instead
>     for readability.

Thanks for this.

--
-- Stephe

_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev

Reply via email to