Stephen Leake <[EMAIL PROTECTED]> writes: > Michael Olson <[EMAIL PROTECTED]> writes: > >> * lisp/dvc-utils.el (dvc-ewoc-delete): Move the compatibility >> function for ewoc-delete from dvc-emacs.el to here, and rename it >> dvc-ewoc-delete. Use it throughout instead of ewoc-delete. This >> fixes another XEmacs 21.5 issue. > > I don't understand this fix. > > Previously, we had in dvc-emacs.el: > > (if (not (fboundp 'ewoc-delete)) > (defun ewoc-delete (ewoc &rest nodes) > ... > > Now, we have in dvc-utils.el: > > (if (fboundp 'ewoc-delete) > (defalias 'dvc-ewoc-delete 'ewoc-delete) > (defun dvc-ewoc-delete (ewoc &rest nodes) > ... > > Why is this better? > > It seems to me it is better to use the Emacs name 'ewoc-delete', so > when XEmacs implements ewoc-delete, we don't have to change so much > code.
What I did is better because we should *never* be providing
implementations of functions that could conflict with the namespace of
another package. If we screw something up, then the developers of
another unrelated package have a very difficult time trying to replicate
the bug reporter's environment, and will be (rightfully) pissed at us.
I've had this happen to me as a developer of Emacs Muse, when another
package provided a bad implementation of replace-regexp-in-string.
I would like to eventually eliminate dvc-emacs.el and dvc-xemacs.el,
turn them into dvc-compat.el, and change every function definition in
these files to have the prefix "dvc-".
--
Michael Olson -- FSF Associate Member #652 |
http://mwolson.org/ -- Jabber: mwolson_at_hcoop.net | /` |\ | | |
Programmer -- Hobbies: Lisp, HCoop | |_] | \| |_|
Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |
pgpolnmzZtwFR.pgp
Description: PGP signature
_______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
