() Matthieu Moy <[EMAIL PROTECTED]>
() Mon, 04 Aug 2008 15:07:56 +0200
But PATH wont tell you whether you should use gdiff or diff. dvc-site
was introduced to avoid the need to patch DVC in the case where
executables didnt have the expected name (I had in mind the freebsd
port, which had only this as a patch).
I agree, having to patch DVC is not a good resolution.
If you remove it, please provide a way for the guy installing DVC to
point diff to gdiff and patch to gpatch.
I disagree that this decision should be up to the guy installing DVC.
IMHO, it should be up to the end-user, which implies some variable
settable in ~/.emacs at the least. The case to keep in mind is:
- DVC installed under /usr/local by root
- jrhacker does not have write privs for /usr/local
DVC already supports runtime variables; all the configure-subsituted
values in dvc-site.el are overridable anyway, since they are assigned to
normal Lisp variables. So the minimalist change that i am proposing
would not touch the variable names, just the values. To be more
precise:
- change from: (defvar dvc-site-diff-executable "@DIFF@")
to: (defvar dvc-site-diff-executable "diff")
- incorporate defvars into some other file (probably dvc-defs.el
is a good place) converting to defcustom w/ docstrings, etc.
- delete dvc-site.el.in and related configury support
In the end, from jrhacker's pov, the preferred way to express gdiff over
diff remains the same, namely by adding to ~/.emacs one of the forms:
(setq dvc-site-diff-executable "gdiff")
(setq dvc-site-diff-executable "/full/path/to/gdiff")
This can be done w/o bothering the guy installing DVC, before, during,
or after, the installation. From root's pov, installing DVC can be
done even if those programs are not available (perhaps to be installed
later). Lastly, from DVC hackers (and janitor) pov, there is less
maintenance burden, while providing continuity -- i.e., more SLACK!
thi
_______________________________________________
Dvc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/dvc-dev
