Thien-Thi Nguyen <[EMAIL PROTECTED]> writes: > I disagree that this decision should be up to the guy installing DVC. > IMHO, it should be up to the end-user, which implies some variable > settable in ~/.emacs at the least. The case to keep in mind is:
The guy installing DVC should have a way to have an installation that _works_. I didn't test, but I suspect the FreeBSD patched because we require GNU diff and GNU path, so the installer _must_ have a way to say "hey, I need to use GNU patch, not plain patch". Then, the user can override it in his .emacs, and if it does so, the default provided by the installer is ignored. > - change from: (defvar dvc-site-diff-executable "@DIFF@") > to: (defvar dvc-site-diff-executable "diff") Your default value assumes that "diff" will work. Giving the user a default which doesn't work is bad. If there's no value OK for everybody, I don't see how you can do without asking the installer to provide it (ideally, the configure script should check that diff will work and fall back to gdiff otherwise). -- Matthieu _______________________________________________ Dvc-dev mailing list [email protected] https://mail.gna.org/listinfo/dvc-dev
