On Wed, 22 Oct 2008 12:01:16 -0600 "Williams, Mitch A" <[EMAIL PROTECTED]> wrote:
> Jeff Garzik wrote: > > > > >Stephen Hemminger wrote: > >> The name in the ring is only used once during setup so it shouldn't > >> be in the data structure. > >> > >> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > [snip] > > > >ACK > > > >for what it's worth... I am following DaveM's lead, and waiting until > >net-next opens to start taking patches for 2.6.29. He wants > >us to focus > >on bug fixing for now. > > > >So, please resend once the merge window opens... thanks. > > > > NAK. Seriously. Don't resend this. NAK. > > That string DOES get used later, like when you cat /proc/interrupts. > So you can't allocate it on the stack. It's got to be persistent, > just like we have it. Heck, look at the declaration for > request_irq(). The devname param is declared as const char *. > > So NAK. Same for igb and ixgbe. Don't do this. > > -Mitch The comments were right, this needs to stay, although it might be better to use a bigger field to allow full width of IFNAME+5 ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel
