On Fri, 20 Mar 2009, Stephen Hemminger wrote: > Convert ixgbe to use net_device_ops properly. > Rather than changing the select_queue function pointer > just change number of available transmit queues. > > Signed-off-by: Stephen Hemminger <[email protected]> > > --- > drivers/net/ixgbe/ixgbe_dcb_nl.c | 48 > +++++++++++++++++---------------------- > 1 file changed, 21 insertions(+), 27 deletions(-) > > --- a/drivers/net/ixgbe/ixgbe_dcb_nl.c 2009-03-20 09:01:19.643651162 > -0700 > +++ b/drivers/net/ixgbe/ixgbe_dcb_nl.c 2009-03-20 09:11:09.645652169 > -0700 > @@ -102,12 +102,6 @@ static u8 ixgbe_dcbnl_get_state(struct n > return !!(adapter->flags & IXGBE_FLAG_DCB_ENABLED); > } > > -static u16 ixgbe_dcb_select_queue(struct net_device *dev, struct sk_buff > *skb) > -{ > - /* All traffic should default to class 0 */ > - return 0; > -} > - > static u8 ixgbe_dcbnl_set_state(struct net_device *netdev, u8 state) > { > u8 err = 0; > @@ -135,7 +129,7 @@ static u8 ixgbe_dcbnl_set_state(struct n > kfree(adapter->rx_ring); > adapter->tx_ring = NULL; > adapter->rx_ring = NULL; > - netdev->select_queue = &ixgbe_dcb_select_queue; > + netdev->real_num_tx_queues = 1;
NAK. The point of dcb_select_queue() isn't because DCB mode only uses 1 Tx queue. DCB has 8 priorities, and allocates 8 Tx queues, one for each priority. The DCB spec says that any traffic not being filtered by some kind of mechanism needs to go through priority 0, or queue 0. So select_queue is meant to tag all traffic to queue 0, then have the attached qdisc and tc filters get the majority of the traffic into the different priority queues. If we did not push the unfiltered traffic into queue 0, then skb_tx_hash() would put traffic randomly into queues with higher priority, which is not what we want. I'd prefer your original patch to fix this up, where you check if DCB is enabled, and return 0. -PJ Waskiewicz ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel
