On Fri, 20 Mar 2009, Stephen Hemminger wrote:
> The default select queue function in the kernel is:
>
> static struct netdev_queue *dev_pick_tx(struct net_device *dev,
> struct sk_buff *skb)
> {
> const struct net_device_ops *ops = dev->netdev_ops;
> u16 queue_index = 0;
>
> if (ops->ndo_select_queue)
> queue_index = ops->ndo_select_queue(dev, skb);
> else if (dev->real_num_tx_queues > 1)
> queue_index = skb_tx_hash(dev, skb);
>
> skb_set_queue_mapping(skb, queue_index);
> return netdev_get_tx_queue(dev, queue_index);
> }
>
> So if driver (re)sets real_num_tx_queues to 1 then queue_index will always
> 0 and all traffic will go to one queue. This is the same as having your
> own select_queue function.
I see your point, but it is a hack in my opinion. The device will have 8
real Tx queues, not 1. I'd much rather go with the original proposal,
since if the code in dev_pick_tx() changed, it could silently break ixgbe.
-PJ Waskiewicz
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
