On 04/23/2009 05:15 PM, Rafael J. Wysocki wrote: > On Thursday 23 April 2009, Jiri Slaby wrote: >> 4a865905f685eaefaedf6ade362323dc52aa703b >> (PCI PM: Make pci_set_power_state() handle devices with no PM support) >> breaks e1000 after being kexec'ed. These reverts fix the problem: >> Revert "PCI PM: Make pci_set_power_state() handle devices with no PM >> support" >> Revert "PCI PM: Introduce __pci_[start|complete]_power_transition() >> (rev. 2)" >> >> I reverted the second one > > I don't think it can be reverted.
But it works :). I'm not saying, it's correct to revert them upstream. It was just confirmation, that it causes the problem. >> just for an easy revert of the former one, which is actually the culprit. > > Can you just try to revert the changes in pci_raw_set_power_state() and check > if that has any effect (it shouldn't)? Please send a patch. I'm lost in the changes done there. Let's say against the top of 20090423 next tree. >> e1000: 0000:02:01.0: e1000_probe: Invalid MAC Address >> e1000: 0000:02:01.0: e1000_probe: (PCI-X:33MHz:64-bit) 00:00:00:00:00:00 > > So this is after kexec? yes > What happens if you remove just the > > /* Check if we're already there */ > if (dev->current_state == state) > return 0; > > part from pci_set_power_state()? Will try later. Thanks. ------------------------------------------------------------------------------ Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel
