"Kumar Gopalpet-B05799" <b05...@freescale.com> wrote on 12/24/2009 12:06:09
PM:

> "Kumar Gopalpet-B05799" <b05...@freescale.com>
> 12/24/2009 12:06 PM
>
> To
>
> "David Miller" <da...@davemloft.net>
>
> cc
>
> Krishna Kumar2/India/i...@ibmin, <ying...@kernel.org>, <e1000-
> de...@lists.sourceforge.net>, <net...@vger.kernel.org>, <netdev-
> ow...@vger.kernel.org>, <avoront...@ru.mvista.com>,
> <ga...@kernel.crashing.org>
>
> Subject
>
> RE: gianfar select_queue bogosity
>
>
>
> >-----Original Message-----
> >From: David Miller [mailto:da...@davemloft.net]
> >Sent: Thursday, December 24, 2009 12:00 PM
> >To: Kumar Gopalpet-B05799
> >Cc: krkum...@in.ibm.com; ying...@kernel.org;
> >e1000-devel@lists.sourceforge.net; net...@vger.kernel.org;
> >netdev-ow...@vger.kernel.org; avoront...@ru.mvista.com;
> >ga...@kernel.crashing.org
> >Subject: Re: gianfar select_queue bogosity
> >
> >From: "Kumar Gopalpet-B05799" <b05...@freescale.com>
> >Date: Thu, 24 Dec 2009 11:34:23 +0530
> >
> >> What if I want to maintaing a 1-1 mapping b/w the Rx/Tx queues.
> >> For eg., I want a packet received on queue-1 on eth0 to be forwarded
> >> on to queue-1 on eth1.
> >
> >That's what the default code does when forwarding/bridging!
> >
> >And for locally generated packets it uses the flow hash.
> >
> >What do you think we do by default?  Go read the code :-)
> >
>
> OOPS ..I am really sorry. I should have given a little thought before
> providing the gfar_select_queue( ) function. Thanks for the pointer.
>
> But then, on the Rx-side, we should also set the "queue_mapping" as
> "queue_mapping +1", since skb_get_rx_queue( ) returns "queue_mapping
> -1". Is this correct ?

Don't use +1/-1 anywhere. Instead of calling skb_set_queue_mapping,
call skb_record_rx_queue which does the +1.

- KK


------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel

Reply via email to