>-----Original Message-----
>From: Krishna Kumar2 [mailto:[email protected]] 
>Sent: Thursday, December 24, 2009 12:30 PM
>To: Kumar Gopalpet-B05799
>Cc: [email protected]; David Miller; 
>[email protected]; [email protected]; 
>[email protected]; [email protected]; 
>[email protected]
>Subject: RE: gianfar select_queue bogosity
>
>
>
>"Kumar Gopalpet-B05799" <[email protected]> wrote on 
>12/24/2009 12:06:09
>PM:
>
>> "Kumar Gopalpet-B05799" <[email protected]>
>> 12/24/2009 12:06 PM
>>
>> To
>>
>> "David Miller" <[email protected]>
>>
>> cc
>>
>> Krishna Kumar2/India/i...@ibmin, <[email protected]>, <e1000- 
>> [email protected]>, <[email protected]>, <netdev- 
>> [email protected]>, <[email protected]>, 
>> <[email protected]>
>>
>> Subject
>>
>> RE: gianfar select_queue bogosity
>>
>>
>>
>> >-----Original Message-----
>> >From: David Miller [mailto:[email protected]]
>> >Sent: Thursday, December 24, 2009 12:00 PM
>> >To: Kumar Gopalpet-B05799
>> >Cc: [email protected]; [email protected]; 
>> >[email protected]; [email protected]; 
>> >[email protected]; [email protected]; 
>> >[email protected]
>> >Subject: Re: gianfar select_queue bogosity
>> >
>> >From: "Kumar Gopalpet-B05799" <[email protected]>
>> >Date: Thu, 24 Dec 2009 11:34:23 +0530
>> >
>> >> What if I want to maintaing a 1-1 mapping b/w the Rx/Tx queues.
>> >> For eg., I want a packet received on queue-1 on eth0 to be 
>> >> forwarded on to queue-1 on eth1.
>> >
>> >That's what the default code does when forwarding/bridging!
>> >
>> >And for locally generated packets it uses the flow hash.
>> >
>> >What do you think we do by default?  Go read the code :-)
>> >
>>
>> OOPS ..I am really sorry. I should have given a little 
>thought before 
>> providing the gfar_select_queue( ) function. Thanks for the pointer.
>>
>> But then, on the Rx-side, we should also set the "queue_mapping" as 
>> "queue_mapping +1", since skb_get_rx_queue( ) returns "queue_mapping 
>> -1". Is this correct ?
>
>Don't use +1/-1 anywhere. Instead of calling 
>skb_set_queue_mapping, call skb_record_rx_queue which does the +1.
>
>
Yes, skb_recore_rx_queue will do the required.
Will send out a patch. 

Thanks KK. 


--

Thanks
Sandeep


------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel

Reply via email to