On Tue, Jul 27, 2010 at 03:41:46PM -0700, Jeff Kirsher wrote: > On Tue, Jul 27, 2010 at 15:34, Sonny Rao <[email protected]> wrote: > > This patch is similar to what was fixed in ixgbe in this patch: > > > > http://marc.info/?l=e1000-devel&m=126593062701537&w=3 > > > > We should add read memory barriers to all the similar cases across the > > Intel ethernet driver family. In the case of ixgbevf I've also added > > a missing barrier to the clean_tx_irq path because I missed it in my > > last patch. > > > > Without the barrier a processor can speculate a load ahead of the load > > which looks at the status bit and get stale information causing a > > number of different issues including invalid packet length, NULL > > pointers, or bad data since checksumming was assumed to be done > > in hardware. > > > > Signed-off-by: Milton Miller <[email protected]> > > Signed-off-by: Sonny Rao <[email protected]> > > cc: stable <[email protected]> > > > > I already have a similar patch in my queue from you Sonny, although I > see that this patch has made a few more changes. Is this version 2?
Well, the previous one was for the clean_tx_irq functions this one is for the clean_rx_irq functions. I'd gotten the two confused when I referenced Anton's original patch -- which was also a clean_rx_irq patch. So they are touching different code paths but fixing similar problems. -- Sonny Rao, LTC OzLabs, BML team ------------------------------------------------------------------------------ The Palm PDK Hot Apps Program offers developers who use the Plug-In Development Kit to bring their C/C++ apps to Palm for a share of $1 Million in cash or HP Products. Visit us here for more details: http://ad.doubleclick.net/clk;226879339;13503038;l? http://clk.atdmt.com/CRS/go/247765532/direct/01/ _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
