On Tue, Jul 27, 2010 at 16:05, Sonny Rao <[email protected]> wrote: > On Tue, Jul 27, 2010 at 03:45:42PM -0700, Jeff Kirsher wrote: >> >> You also seem to be missing igb. > > This patch is similar to what was fixed in ixgbe in this patch: > > http://marc.info/?l=e1000-devel&m=126593062701537&w=3 > > We should add read memory barriers to all the similar cases across the > Intel ethernet driver family. In the case of ixgbevf, igb, and igbvf > I've also added a missing barrier to the clean_tx_irq path because I > missed it in my last patch. > > Without the barrier a processor can speculate a load ahead of the load > which looks at the status bit and get stale information causing a > number of different issues including invalid packet length, NULL > pointers, or bad data since checksumming was assumed to be done > in hardware. > > v2: I missed the e100 the first time > v3: I missed igb and igbvf, third time's the charm? > > Signed-off-by: Milton Miller <[email protected]> > Signed-off-by: Sonny Rao <[email protected]> > cc: stable <[email protected]> >
Thanks, I have added the patch to my queue. -- Cheers, Jeff ------------------------------------------------------------------------------ The Palm PDK Hot Apps Program offers developers who use the Plug-In Development Kit to bring their C/C++ apps to Palm for a share of $1 Million in cash or HP Products. Visit us here for more details: http://ad.doubleclick.net/clk;226879339;13503038;l? http://clk.atdmt.com/CRS/go/247765532/direct/01/ _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
