On Thu, 2010-12-09 at 02:40 +0000, Asbjoern Sloth Toennesen wrote: > Swap argument order in order to avoid checkpatch treating it as an > unary operation, instead of an binary one, and obtain consistency > with the 3 other similar assignments in netdev.c (tdlen & rdlen). > > This patch fixes 3 checkpatch errors.
You have got to be kidding. If the checkpatch warning offends you, fix the bug in checkpatch instead of changing perfectly good code. Ben. > Signed-off-by: Asbjoern Sloth Toennesen <[email protected]> > --- > drivers/net/e1000e/netdev.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c > index bb6a1f5..bdd3774 100644 > --- a/drivers/net/e1000e/netdev.c > +++ b/drivers/net/e1000e/netdev.c > @@ -2059,7 +2059,7 @@ int e1000e_setup_tx_resources(struct e1000_adapter > *adapter) > struct e1000_ring *tx_ring = adapter->tx_ring; > int err = -ENOMEM, size; > > - size = sizeof(struct e1000_buffer) * tx_ring->count; > + size = tx_ring->count * sizeof(struct e1000_buffer); > tx_ring->buffer_info = vzalloc(size); > if (!tx_ring->buffer_info) > goto err; > @@ -2094,7 +2094,7 @@ int e1000e_setup_rx_resources(struct e1000_adapter > *adapter) > struct e1000_buffer *buffer_info; > int i, size, desc_len, err = -ENOMEM; > > - size = sizeof(struct e1000_buffer) * rx_ring->count; > + size = rx_ring->count * sizeof(struct e1000_buffer); > rx_ring->buffer_info = vzalloc(size); > if (!rx_ring->buffer_info) > goto err; > @@ -2151,7 +2151,7 @@ static void e1000_clean_tx_ring(struct e1000_adapter > *adapter) > e1000_put_txbuf(adapter, buffer_info); > } > > - size = sizeof(struct e1000_buffer) * tx_ring->count; > + size = tx_ring->count * sizeof(struct e1000_buffer); > memset(tx_ring->buffer_info, 0, size); > > memset(tx_ring->desc, 0, tx_ring->size); -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. ------------------------------------------------------------------------------ This SF Dev2Dev email is sponsored by: WikiLeaks The End of the Free Internet http://p.sf.net/sfu/therealnews-com _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
