include/net/netlink.h: In function ‘nlmsg_parse’:
include/net/netlink.h:368:21: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
include/net/netlink.h: In function ‘nlmsg_validate’:
include/net/netlink.h:401:21: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
Seen with gcc (GCC) 4.6.3 20120306 (Red Hat 4.6.3-2).
The result of nlmsg_msg_size() is always compared to
nlmsghdr.nlmsg_len, which is unsigned.
Clean up: nlmsg_padlen() is no longer used.
Signed-off-by: Chuck Lever <chuck.le...@oracle.com>
---
include/net/netlink.h | 11 +----------
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/include/net/netlink.h b/include/net/netlink.h
index e025043..27c7ab7 100644
--- a/include/net/netlink.h
+++ b/include/net/netlink.h
@@ -258,7 +258,7 @@ extern int nla_append(struct sk_buff *skb, int
attrlen,
* nlmsg_msg_size - length of netlink message not including padding
* @payload: length of message payload
*/
-static inline int nlmsg_msg_size(int payload)
+static inline unsigned int nlmsg_msg_size(int payload)
{
return NLMSG_HDRLEN + payload;
}
@@ -273,15 +273,6 @@ static inline int nlmsg_total_size(int payload)
}
/**
- * nlmsg_padlen - length of padding at the message's tail
- * @payload: length of message payload
- */
-static inline int nlmsg_padlen(int payload)
-{
- return nlmsg_total_size(payload) - nlmsg_msg_size(payload);
-}
-
-/**
* nlmsg_data - head of message payload
* @nlh: netlink message header
*/
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
