include/linux/skbuff.h: In function ‘skb_is_recycleable’:
include/linux/skbuff.h:2568:26: warning: comparison between signed
and unsigned integer expressions [-Wsign-compare]
Seen with gcc (GCC) 4.6.3 20120306 (Red Hat 4.6.3-2).
Introduced originally in commit 04a4bb55, Oct 1 2008; copied into
the include/linux/skbuff.h header in commit 3d153a7c, Oct 13 2011.
Signed-off-by: Chuck Lever <chuck.le...@oracle.com>
---
include/linux/skbuff.h | 5 +++--
net/core/skbuff.c | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 19a0c87..b701217 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -590,7 +590,7 @@ static inline struct sk_buff *alloc_skb_fclone(unsigned int
size,
}
extern void skb_recycle(struct sk_buff *skb);
-extern bool skb_recycle_check(struct sk_buff *skb, int skb_size);
+extern bool skb_recycle_check(struct sk_buff *skb, unsigned int skb_size);
extern struct sk_buff *skb_morph(struct sk_buff *dst, struct sk_buff *src);
extern int skb_copy_ubufs(struct sk_buff *skb, gfp_t gfp_mask);
@@ -2642,7 +2642,8 @@ static inline void skb_checksum_none_assert(const struct
sk_buff *skb)
bool skb_partial_csum_set(struct sk_buff *skb, u16 start, u16 off);
-static inline bool skb_is_recycleable(const struct sk_buff *skb, int skb_size)
+static inline bool skb_is_recycleable(const struct sk_buff *skb,
+ unsigned int skb_size)
{
if (irqs_disabled())
return false;
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index fe00d12..1bdc1b0 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -677,7 +677,7 @@ EXPORT_SYMBOL(skb_recycle);
* reference count dropping and cleans up the skbuff as if it
* just came from __alloc_skb().
*/
-bool skb_recycle_check(struct sk_buff *skb, int skb_size)
+bool skb_recycle_check(struct sk_buff *skb, unsigned int skb_size)
{
if (!skb_is_recycleable(skb, skb_size))
return false;
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
