On Tue, Jun 11, 2013 at 04:50:44PM -0700, Jesse Brandeburg wrote:
> On Tue, 11 Jun 2013 13:35:05 -0700
> Russell King - ARM Linux <[email protected]> wrote:
> > As part of my review of all this stuff, I'm wondering whether a helper
> > to set both masks makes sense. Something like:
> >
> > static inline int dma_set_masks(struct device *dev, u64 mask)
>
> it doesn't need to be inline, it is never called in hotpath.
If it goes into linux/dma-mapping.h as a simple helper it does, otherwise
you'll get "declared but not used" warnings.
> > {
> > int ret = dma_set_mask(dev, mask);
> > if (ret == 0)
> > dma_set_coherent_mask(dev, mask);
> > return ret;
> > }
> >
> > "dma_set_masks()" is a little too close to dma_set_mask() though; and
>
> how about dma_set_mask_and_coherent(...)
Yea, I'm happy with that.
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
