On Tue, Jun 11, 2013 at 11:12:30AM -0700, Jesse Brandeburg wrote:
> This is my proposed change to the intel drivers. Comments?
>
> + if (!dma_set_mask(&pdev->dev, DMA_BIT_MASK(64))) {
> + pci_using_dac = true;
> + /* coherent mask for the same size will always succeed if
> + * dma_set_mask does
> + */
> + dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64));
> + } else if (!dma_set_mask(&pdev->dev, DMA_BIT_MASK(32))) {
> + pci_using_dac = false;
> + dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
> + } else {
> + dev_err(&pdev->dev, "%s: DMA configuration failed: %d\n",
> + __func__, err);
> + err = -EIO;
> + goto err_dma;
> }
>
So, will you be going with this change rather than mine, which apparantly
Jeff queued? Please let me know what you decide so I can keep my private
git tree in sync with what you've decided to avoid conflicting with
further dma-mask changes which I'm working on.
Thanks.
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
