On Mon, Oct 07, 2013 at 02:10:43PM -0400, Tejun Heo wrote: > On Wed, Oct 02, 2013 at 12:48:21PM +0200, Alexander Gordeev wrote: > > Make pci_msix_table_size() to return a error code if the device > > does not support MSI-X. This update is needed to facilitate a > > forthcoming re-design MSI/MSI-X interrupts enabling pattern. > > > > Device drivers will use this interface to obtain maximum number > > of MSI-X interrupts the device supports and use that value in > > the following call to pci_enable_msix() interface. > > Hmmm... I probably missed something but why is this necessary? To > discern between -EINVAL and -ENOSPC? If so, does that really matter?
pci_msix_table_size() is kind of helper and returns 0 if a device does not have MSI-X table. If we want drivers to use it we need return -EINVAL for MSI-X incapable/disabled devices. Nothing about -ENOSPC. > tejun -- Regards, Alexander Gordeev agord...@redhat.com ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
