On Fri, 2013-11-22 at 22:07 -0800, Guenter Roeck wrote: > The hwmon subsystem is used by various network drivers to report temperature > sensor and other information. Unfortunately, its use is often not correct. > Typical errors are that the mandatory name sysfs attribute is not created, > that the temperature sensor index starts with 0 instead of 1, and/or that > sysfs attributes are created after the hwmon device was created.
As it happens, I was just looking at what we do in sfc (drivers/net/ethernet/sfc/mcdi_mon.c) and wondering why I made it create the hwmon device before the attributes. I think I avoided the other bugs though. Ben. > The following sequence of patches fixes most of the problems. > > The igb patches have been tested with real hardware; the others are compile > tested only. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
