On Fri, 2013-11-22 at 22:07 -0800, Guenter Roeck wrote: > Simplify the code. Attach hwmon sysfs attributes to hwmon device > instead of pci device. Avoid race conditions caused by attributes > being created after hwmon device registration. Implicitly > (through hwmon API) add mandatory 'name' sysfs attribute. > > Other cleanup: > > Instead of allocating memory for hwmon attributes, move attributes > and all other hwmon related data into struct hwmon_buff and allocate > the entire structure using devm_kzalloc. > > Check return value from calls to igb_add_hwmon_attr() one by one > instead > of logically combining them all together. > > Signed-off-by: Guenter Roeck <li...@roeck-us.net> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 8 ++- > drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c | 76 > ++++++++++-------------- > 2 files changed, 36 insertions(+), 48 deletions(-)
I have added this to my queue, thanks!
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
