(2014/01/11 1:43), Vick, Matthew wrote: > On 1/9/14, 10:02 PM, "Ken ICHIKAWA" <[email protected]> wrote: > >> 82575 only has software timestamping capability and it doesn't >> have PTP Hardware Clocks. Therefore, -1 has to be specified >> to the phc_index for ethtool's get_ts_info, otherwise a wrong >> value will be set to the phc_index. >> >> Signed-off-by: Ken ICHIKAWA <[email protected]> >> --- >> drivers/net/ethernet/intel/igb/igb_ethtool.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c >> b/drivers/net/ethernet/intel/igb/igb_ethtool.c >> index 1df0237..d9bd614 100644 >> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c >> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c >> @@ -2360,6 +2360,7 @@ static int igb_get_ts_info(struct net_device *dev, >> SOF_TIMESTAMPING_TX_SOFTWARE | >> SOF_TIMESTAMPING_RX_SOFTWARE | >> SOF_TIMESTAMPING_SOFTWARE; >> + info->phc_index = -1; >> return 0; >> case e1000_82576: >> case e1000_82580: >> -- >> 1.8.2.1 > > Good catch on this! One slight modification I would like to see instead > though is to move the if (adapter->ptp_clock) section from the following > cases to above the switch statement. adapter->ptp_clock will always be > NULL for 82575, so that logic should hold just fine. > > If you would like, I can submit a patch to resolve this with your > Reported-by. Would you prefer to handle the rewrite or would you like me > to? > > Cheers, > Matthew
Thank you for your comment and I'm sorry about my late reply. I'll rewrite this patch and send it soon. Thanks, Ken Ichikawa ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
