> From: Gangfeng Huang [gangfeng.hu...@ni.com]
> Sent: Wednesday, October 28, 2015 6:47 PM
> To: e1000-devel@lists.sourceforge.net
> Subject: [E1000-devel] [PATCH net-next 1/2] igb: add function to set I210     
>   transmit mode
> 
> I210 supports two transmit modes, legacy and Qav. The transmit mode is
> configured in TQAVCTRL.QavMode register. Before this patch igb driver
> only support legacy mode. This patch makes it possible to configure the
> transmit mode.

Should the i211 (largely similar part) support this as well?

> 
> Example:
> Get the transmit mode:
> $ echo /sys/class/net/eth0/qav_mode

I think you mean "$ cat /sys/class/net/eth0/qav_mode 
> 0
> Set transmit mode to qav mode
> $ echo 1 > /sys/class/net/eth0/qav_mode
>
> Tested:
> Setting /sys/class/net/eth0/qav_mode to Qav mode,
>  1) Switch back and forth between Qav mode and legacy mode
>  2) Send/recv packets in both mode.

> Signed-off-by: Gangfeng Huang <gangfeng.hu...@ni.com>
> ---
>  drivers/net/ethernet/intel/igb/e1000_defines.h |   21 +++
>  drivers/net/ethernet/intel/igb/e1000_regs.h    |    7 +
>  drivers/net/ethernet/intel/igb/igb.h           |    5 +
>  drivers/net/ethernet/intel/igb/igb_main.c      |  182 
> +++++++++++++++++++++++-
>  4 files changed, 213 insertions(+), 2 deletions(-)

> <snip>
> ...
>  #define MAXIMUM_ETHERNET_VLAN_SIZE 1522

I notice that if I enable qav_mode I am unable to set the MTU beyond 1514, 
however there does not seem to be any check to either keep qav_mode from being 
enabled on larger MTUs or to change the MTU to a lower size if qav_mode is 
enabled on a system with jumbo frames:
----------------------------
u1485:[0]/root> cat /sys/class/net/eth3/qav_mode 
1
u1485:[0]/root> ifconfig eth3|grep MTU
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
u1485:[0]/root> ifconfig eth3 mtu 9000
SIOCSIFMTU: Invalid argument
u1485:[0]/root> echo 0 > /sys/class/net/eth3/qav_mode 
u1485:[0]/root> ifconfig eth3 mtu 9000
u1485:[0]/root> echo 1 > /sys/class/net/eth3/qav_mode 
u1485:[0]/root> ifconfig eth3|grep MTU
          UP BROADCAST RUNNING MULTICAST  MTU:9000  Metric:1
u1485:[0]/root> cat /sys/class/net/eth3/qav_mode 
1
u1485:[0]/root> 
------------------------------------------------------------------------------
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit 
http://communities.intel.com/community/wired

Reply via email to