>-----Original Message----- >From: zhuyj [mailto:zyjzyj2...@gmail.com] >Sent: Wednesday, April 27, 2016 1:56 AM >To: Laszlo Fekete <blackl...@ktk.bme.hu> >Cc: e1000-devel@lists.sourceforge.net; Tantilov, Emil S ><emil.s.tanti...@intel.com>; jay.vosbu...@canonical.com >> Jay Vosburgh ><jay.vosbu...@canonical.com> >Subject: Re: [E1000-devel] i40e bonding promisc issue > >Hi, > >The patches are too many. Based on the latest linux kernel, I modified >the patch in the link:http://patchwork.ozlabs.org/patch/561848/ > >If the root cause is correct, the following patch should fix this >problem. This patch is based on the analysis. >And it is only for test. Please let me know the test result. > >Thanks a lot. >Zhu Yanjun > > From 57602f5ceafb2bfddfe222ea63ff7444179d8ac9 Mon Sep 17 00:00:00 2001 >From: Zhu Yanjun <zyjzyj2...@gmail.com> >Date: Wed, 27 Apr 2016 01:51:51 -0700 >Subject: [PATCH 1/1] i40e: synchronize link_up and link_speed of a slave > interface > >Similar to ixgbe nic, i40e nic needs the similar logic to handle >the synchronization of link_up and link_speed of a slave interface. >To all the slave interfaces, the link_speed and link_up should be >synchronized since the time span between link_up and link_speed >will make some virtual NICs not work well, such as a bonding driver >in 802.3ad mode. > >Signed-off-by: Zhu Yanjun <zyjzyj2...@gmail.com> >--- > drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c >b/drivers/net/ethernet/intel/i40e/i40e_main.c >index 3449129..6bb178c 100644 >--- a/drivers/net/ethernet/intel/i40e/i40e_main.c >+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c >@@ -6133,6 +6133,10 @@ static void i40e_link_event(struct i40e_pf *pf) > new_link == netif_carrier_ok(vsi->netdev))) > return; > >+ if ((vsi->netdev->flags & IFF_SLAVE) && >+ (new_link_speed == 0)) >+ return; >+ > if (!test_bit(__I40E_DOWN, &vsi->state)) > i40e_print_link_message(vsi, new_link);
Making link decisions based on whether the interface is part of a bond was a bad idea for ixgbe and is still a bad idea for i40e (or any other driver for that matter). Thanks, Emil ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
