Re: [E1000-devel] [PATCH 1/1] ixgbe: write flush vfta registers

[Lino Sanfilippo]

Hi,

> 
> Sometimes vfta registers can not be written successfully in dcb mode.
> This is very occassional. When the ixgbe nic runs for a very long time,
> sometimes this bug occurs. But after IXGBE_WRITE_FLUSH is executed,
> this bug never occurs.
> 
> Signed-off-by: Zhu Yanjun <zyjzyj2...@gmail.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c 
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index bd93d82..1221cfb 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -4138,8 +4138,10 @@ static void ixgbe_vlan_promisc_enable(struct 
> ixgbe_adapter *adapter)
>       }
>  
>       /* Set all bits in the VLAN filter table array */
> -     for (i = hw->mac.vft_size; i--;)
> +     for (i = hw->mac.vft_size; i--;) {
>               IXGBE_WRITE_REG(hw, IXGBE_VFTA(i), ~0U);
> +             IXGBE_WRITE_FLUSH(hw);
> +     }

Should it not be sufficient to do the flush only once, at the end of the 
function?

Regards,
Lino

------------------------------------------------------------------------------
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit 
http://communities.intel.com/community/wired