Sometimes Gerrit unnecessary slows down the development - you have to wait for somebody to review your changes. It is especially painful when you handle several things simultaneously. So I'm not sure if we should make it the mandatory step after becoming the committer. Every committer can take the code and adjust it when they think sth can be refactored/implement in better way. Hovever I think, introducing some changes that can break sth/block sb or you are not sure if it is correct we should commit changes via Gerrit to get feedback,
+1 for preparing the Hudson build for E4 Daniel From: Lars Vogel <[email protected]> To: E4 Project developer mailing list <[email protected]>, Date: 11/21/2013 06:56 PM Subject: [e4-dev] Mandatory Gerrit usage for the e4 project? Sent by: [email protected] Hi, I grew very found of using Gerrit instead of direct pushes to the Git repo. I see the following advantages: 1.) I can validate myself, if I pushed the right thing. I frequently see in Gerrit that I pushed unintentially whitespace and I can correct that before I commit 2.) I document what I did for others 3.) Others have the possibility to see what I did and can comment or learn from it 4.) It is IMHO fair to Eclipse contributors as I use the same workflow as contributors What is the general opinion about Gerrit? If the majority of e4 committers is in favor of using it, I would like to suggest that direct pushes are disabled so that every contribution would go via Gerrit. We could (in the future) also setup Gerrit build triggers to validate that change don't break the build. Best regards, Lars_______________________________________________ e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/e4-dev
_______________________________________________ e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/e4-dev
