Some thoughts
On Tue, Feb 18, 2014 at 5:27 AM, Lars Vogel <[email protected]> wrote: > Would be nice if we can migrate the editor to the PDE tools. I think were > is some cleanup required in the model editor, for example we need to move > to the new translation service. Dirk Fauth and I'm are working on it. The > model editor uses also a special layout which looks really bad on the new > dark theme I'm working on, so I plan to clean that up. Other than that I > think we should be fine to move. > > Anyone interested in writing unit tests for the editor? I think that is > required before we can move it to PDE. Btw. as M6 is API and M7 is feature > freeze for Luna I think the move can only be done for Luna+1. > I think PDE is the correct place for these tools to go. They could even remain separate features that could be gathered at the PDE UI feature level or at the Eclipse SDK product level (so not really tied to the PDE UI feature). Some concerns: 1) The tools need to be properly NLSed before they can graduate. 2) There should be some minimal JUnit test plugin so that as the editor plugins continue to evolve they can have their tests updated and they can be run as part of the build. I wouldn't expect it to be comprehensive, at least not at this point. I could help with the "can be run as part of the build" part. 3) to be included in the SDK they would need some docs, at least the editor description for the editor like http://help.eclipse.org/kepler/index.jsp?topic=%2Forg.eclipse.pde.doc.user%2Fguide%2Ftools%2Feditors%2Fproduct_editor%2Feditor.htm&cp=4_3_2_4and possibly a page that describes how o.e.e4.tools.css.spy works. 4) The Eclipse SDK (including PDE) is a +0 component, and only depends on org.eclipse.emf.common.feature.group and org.eclipse.emf.ecore.feature.group. Those 2 EMF bundles are currently provided to us as a -0.5 component (the rest of EMF is a +1 component). So if the editor has other emf dependencies (I found at least org.eclipse.emf.edit) then we need to solve that build problem before it can graduate. It's not as simple as saying we'll just pull in that dependency. 5) I think Lars it right that the editor might need to go into Luna+1 6) I'd like to see org.eclipse.e4.tools.css.spy graduate for Luna, if we could. We still should put all of the features into the marketplace for our 0.15 stable build, as that was Kepler compatible. When Luna comes around, we should plan to make the latest versions of our e4 tools that are Luna compatible available in the marketplace as well. Later, Paul -- Paul Webster Hi floor. Make me a sammich! - GIR
_______________________________________________ e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/e4-dev
