Same with concrete classes that aren't extended - mark them final. (And maybe flag interfaces that aren't implemented or abstract classes that aren't extended?)
This is a useful starting point to understanding someone else's code. Also, a couple of refactorings along the lines of: "Give Variables Useful Names" and "Comment Method" would be fantastic :o) Cheers, Dan/tastapod > -----Original Message----- > From: Thomas Singer [mailto:[EMAIL PROTECTED]] > Sent: 30 October 2001 11:58 > To: [EMAIL PROTECTED] > Subject: RE: [Eap-features] Automatically create compiler output path > > > I agree with Alain, that are very refactoring-related wishes, > that would > make sense in IDEA. > > I would add following feature request (95% matching): > > "Make as much hidden as possible" > _________________________________ > Select a method, invoke the action and the method is made > final, if nobody > overrides it. Make it private, if only this class uses this method. > > I would think, this is very easy to implement too, but would > save us a lot > of time, understanding and transforming some old code. > > Best regards > Thomas Singer > > As the code is already parsed by IDEA, I suspect that > "looking for some > smell patterns should be pretty simple. > > >I'd suggest we start simply, and chose the > > features with the highest ROI : > > > > > ************************************************************** > ********* > > very simple to implement <- and -> interesting, but > difficult to do by hand > > > ************************************************************** > ********* > > > >The size related smells : > > > >1� "Too much code": > > > > - find the classes too big (ex. LOC > 2000 ) > > - find the methods too big (ex. LOC > 2000 ) > > - find the classes with too many methods > > - find the classes with too many public members > > ... > > > > > >2� "Too few code": > > (look at http://www.c2.com/cgi/wiki?CodeSmells) > > > >3� "Find the dead code" > > Why maintain code that is never used. > > Number 1 in my list. Requested by many, often. > > > >4� Stupid looking names > > no vowels : String ptrkpppzz = ... > > too short : int pe = ... > > too long with same case > > : boolean thisiscryingforabettercasing = false ; > > ... > > > >5� find duplicate code. > > I installed same (http://sourceforge.net/projects/same/) as an > > external tool. > > It's simple, free, written in java, the code is available... > > It would be more useful if it were integrated in IDEA : > messages would > > include live pointes to the line xxx in the code. > > > > > >.... > >I only chose the basic ones, that could be added in a day > (at least 1,2 and 4) > > > >If was fine for IDEA to start as a super smart editor, but > it's not enough. > >I want more. > >Sorry guys, but you spoiled me by showing what you could do. > > > > > >Alain Ravet > > > _______________________________________________ > Eap-features mailing list > [EMAIL PROTECTED] > http://www.intellij.com/mailman/listinfo/eap-features > *************************************************************************************** This email and any files transmitted with it are confidential and intendeds olely for the use of the individual or entity to whom they are addressed.I f you have received this email in error please notify [EMAIL PROTECTED] immediately. This footnote also confirms that this email message has been swept for thep resence of computer viruses. *************************************************************************************** _______________________________________________ Eap-features mailing list [EMAIL PROTECTED] http://www.intellij.com/mailman/listinfo/eap-features
