Picking up an old thread I didn't get the chance to pick up on yet...
On 13/07/14 14:46, Ward Poelmans wrote:
On Sun, Jul 13, 2014 at 2:30 PM, Jack Perdue <[email protected]> wrote:
Along the same lines, is there any reason
to issues pulls for ECs created with
--try-software-version (with our without
--try-toolchain).
Well, there is no clear line. As I said, ECv2 should make this a lot
easier. For now, it's up to your own judgement: is it just a minor
version update or something major? ...
If not, I can clean out a lot of stuff and
look for more interesting changes to pull. :)
I would suggest that your first try to do the 'interesting stuff':
easyconfigs that don't work with a simple --try-*.
One good reason for making a PR for new easyconfigs (even with only a
bump of the toolchain or software version) is that things will/should
"just work" for others who try to install the same thing later on (i.e.
without needing to use --try-X).
Ward is right though: if this means PRs coming in with
hundreds/thousands of easyconfigs, this would currently be an issue to
get them handled (reviewed, tested & merged), especially w.r.t.
consistency with existing easyconfigs
(https://github.com/hpcugent/easybuild-framework/pull/1005 should help
us a bit there).
If we ever get to finishing the support for the "easyconfig format v2",
this should change things significantly though.
See
https://github.com/hpcugent/easybuild-framework/blob/master/test/framework/easyconfigs/v2.0/toy-with-sections.eb
for an (experimental) example.
In such an easyconfig, bumping the toolchain/version only changes a one
or two lines in an existing file, which significantly simplifies
reviewing (although it does complicate testing a bit, but nothing we
can't figure out).
For now, I agree with Ward's suggestion: if you've obtained a new
easyconfigs via simply using --try-toolchain(-version) and/or
--try-software-version, don't bother in creating a PR for it (we're
already overloaded with tons of easyconfig PRs as is ;-)).
If you need to fix something else to get it to work though then it does
become interesting to contribute it back, so other people don't lose
(tons of) time figuring out a problem you've already fixed.
regards,
Kenneth
