> On 16 Jan 2018, at 14:42, Kenneth Hoste <[email protected]> wrote: > > Dear Jakob, > > On 16/01/2018 14:37, Jakob Schiøtz wrote: >> Hi, >> >> One of my colleagues found an error in one of the easyconfigs that I >> recently made (ASE, t is in the lastest release). Some functionality is >> missing because of a missing dependency. What is the correct way to fix it? >> A PR with a new version of the same easyconfig, or should I make one with >> an updated version number (patch1 or something)? >> >> The latter clearly prevents any doubt about which version is which, but it >> also implies that all software depending on this package need to be updated >> to prevent them from pulling in the broken version. > > Please submit a PR to change the existing easyconfig file in place, which is > OK to do in case of bug fixes like this.
Unfortunately, this is a bit more complicated. The missing dependency is Tkinter, which was removed from the normal Python build (I fully understand why, it took hours to build the dependencies). Unfortunately, the tkinter.py easyblock only works for Python 2.7. I tried making a new easyconfig, but the modules that are being built are different in Python 3, and that is hardcoded into the easyblock. I will try to get a PR through as fast as possible, since it would be great to make it before the 3.5.1 release - but that may not be realistic. :-) Jakob > > > regards, > > Kenneth > >> >> Best regards >> >> Jakob >> >> >> -- >> Jakob Schiøtz, professor, Ph.D. >> Department of Physics >> Technical University of Denmark >> DK-2800 Kongens Lyngby, Denmark >> http://www.fysik.dtu.dk/~schiotz/ >> >> >> > -- Jakob Schiøtz, professor, Ph.D. Department of Physics Technical University of Denmark DK-2800 Kongens Lyngby, Denmark http://www.fysik.dtu.dk/~schiotz/
