Hi Sebastian, Feedback given on https://github.com/easybuilders/easybuild-easyconfigs/pull/9934. :-)
> On 26 Feb 2020, at 15:57, Sebastian Potthoff <[email protected]> > wrote: > > For anyone interested, I opened a PR for a PyTorch Extensions Module ( > https://github.com/easybuilders/easybuild-easyconfigs/pull/9934 ). > > Tests are failing at this point and I have no clue why, yet. Feedback is very > welcome. > > Sebastian > > On 20.02.20 13:54, Jakob Schiøtz wrote: >>> On 20 Feb 2020, at 09.39, Sebastian Potthoff <[email protected]> >>> wrote: >>> >>> Hi, >>> >>> follow-up question: If I create a generic PythonBundle, like >>> "PyTorch-Extensions" what version number would one use? >>> >>> Is it allowed to skip the version? Otherwise I would think of something >>> like 2019a or 2019.01 or similar? (I'm creating it for the foss-2019a >>> toolchain) >> I have not authority here, so feel free to ignore me :-) >> >> I would choose a version number like YYYYMMDD, that way you can fix things >> and make a new release the next day. 2019a would look like a relation to >> the toolchains, and might confuse people. >> >> Jakob >> >> >>> Sebastian >>> >>> On 20.02.20 08:55, Sebastian Potthoff wrote: >>>> Hi Terje, >>>> >>>> many thanks for your insights! This certainly helps a lot. Once I sorted >>>> everything out, I will definitely make a PR :) >>>> >>>> Sebastian >>>> >>>> On 19.02.20 21:28, Terje Kvernes wrote: >>>>> Hi Sebastian, >>>>> >>>>> Without claiming any divine authority on the matter, I would suggest >>>>> separating out googledownloader and plyfile into their own EasyConfigs, >>>>> and keeping the rest of the PyTorch-related extensions in a "PyTorch >>>>> extensions”-bundle. >>>>> >>>>> It is always a tricky question when to extend more “core” packages and >>>>> when to make external bundles, but I’ve certainly started to lean towards >>>>> using bundles more. This usually makes the core packages easier to update >>>>> and reduces the possible dependency collisions between different >>>>> extensions, leaving users to make informed choices (via conflicts when >>>>> required) about what to load. >>>>> >>>>> If possible, could you create pull requests via --new-pr for these >>>>> EasyConfigs? The documentation is fairly straight forward on >>>>> https://easybuild.readthedocs.io/en/latest/Integration_with_GitHub.html. >>>>> I know some of my users are looking for PyTorch extensions, so I (and >>>>> probably many others) would be happy to test and contribute to these >>>>> EasyConfigs. :-) >>>>> >>>>>> On 19 Feb 2020, at 12:57, Sebastian Potthoff >>>>>> <[email protected]> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> I have a question concerning PythonBundles/Packages in general and >>>>>> specifically to an extension of PyTorch: "PyTorch-Geometric". >>>>>> (https://github.com/rusty1s/pytorch_geometric) >>>>>> >>>>>> I created an EC PythonBundle including several PyTorch extension modules >>>>>> needed for PyTorch-Geometric. However my exts_list also inlcudes >>>>>> "googledrivedownloader" and "plyfile". Should these extensions better be >>>>>> installed by separate EasyConfig files? What's the preferred way? >>>>>> >>>>>> There already is a PyTorch PythonPackage EC. Instead of creating a new >>>>>> PythonBundle, should I update the existing EC and add the extensions to >>>>>> this file? And when do I use the PythonBundle instead of the >>>>>> PythonPackage EB? >>>>>> >>>>>> Many thanks for your help >>>>>> Sebastian >>>>>> >>> -- >>> Westfälische Wilhelms-Universität (WWU) Münster >>> WWU IT >>> Sebastian Potthoff, M.Sc. (eScience/HPC) >>> Röntgenstraße 7-13, R.207/208 >>> 48149 Münster >>> Tel. +49 251 83-31640 >>> E-Mail: [email protected] >>> Website: www.uni-muenster.de/it >>> >>> > -- > Westfälische Wilhelms-Universität (WWU) Münster > WWU IT > Sebastian Potthoff, M.Sc. (eScience/HPC) > Röntgenstraße 7-13, R.207/208 > 48149 Münster > Tel. +49 251 83-31640 > E-Mail: [email protected] > Website: www.uni-muenster.de/it > > -- Terje Kvernes Head sysadmin Department of Mathematics University of Oslo
