[ 
https://jira.nuxeo.com/browse/NXP-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=104395#comment-104395
 ] 

Jean-Marc Orliaguet commented on NXP-7671:
------------------------------------------

The hack is needed because of the recent changes done to support class="" on 
page elements such as:

 <page class="documentManagement">

it seems that the code removes all class="..." information on the <body> 
element.

I have tested by creating a new theme from scratch and also in webengine, and 
the correct nxStyle1234 and pageFrame information is generated, however there 
is a problem with the galaxy theme.

the following code should be enough:

                        if (cssSource != null) {
                            cssSource = cssSource.replaceAll("__FLAVOUR__",
                                    ThemeManager.getCollectionCssMarker());
                            themeManager.setNamedObject(themeName, "style",
                                    pageStyle);
                            Utils.loadCss(pageStyle, cssSource, "*");
                        }

(no need to create a ViewType and refer to any "page frame")

so instead I would rather open a ticket to first fix the class="..." feature, 
so that it preserves existing class information. 


> Fix link between the page and it styling
> ----------------------------------------
>
>                 Key: NXP-7671
>                 URL: https://jira.nuxeo.com/browse/NXP-7671
>             Project: Nuxeo Enterprise Platform
>          Issue Type: Sub-task
>            Reporter: Anahide Tchertchian
>            Assignee: Jean-Marc Orliaguet
>
> The generated style name "nxtyle*" was not appearing on the body element => 
> the following changeset was done but it's really hacky so it should be 
> changed and made generic (see changes on class ThemeStylingServiceImpl.java): 
> http://hg.nuxeo.org/nuxeo/nuxeo-theme/rev/6eb2ba47aa50

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
ECM-tickets mailing list
[email protected]
http://lists.nuxeo.com/mailman/listinfo/ecm-tickets

Reply via email to