[ 
https://jira.nuxeo.com/browse/NXP-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=104624#comment-104624
 ] 

Anahide Tchertchian edited comment on NXP-7671 at 10/24/11 5:13 PM:
--------------------------------------------------------------------

Fix registration of resources when order of registration is not the ideal one + 
better comments on generated css file:
http://hg.nuxeo.org/nuxeo/nuxeo-theme/rev/1245815e1af4

TODO: fix the fact that adding an additional style does not link it to the 
page, steps to reproduce:
1. define a new css nuxeo_dm_default2 to override links for instance, and link 
it to the page:
{code}
  <extension target="org.nuxeo.theme.styling.service" point="pages">
    <themePage name="galaxy/default">
      <defaultFlavor>default</defaultFlavor>
      <flavors append="true">
        <flavor>default</flavor>
        <flavor>dark</flavor>
      </flavors>
      <styles append="true">
        <style>nuxeo_dm_default</style>
        <style>nuxeo_dm_default2</style>
      </styles>
    </themePage>
  </extension>
  <extension target="org.nuxeo.theme.styling.service" point="styles">
    <style name="nuxeo_dm_default">
      <path>themes/css/nuxeo_dm_default.css</path>
    </style>
    <style name="nuxeo_dm_default2">
      <path>themes/css/nuxeo_dm_default2.css</path>
    </style>
  </extension>
{code}

nuxeo_dm_default2.css contains only:
{code}
a, a:link, a:visited { color: "red"; text-decoration: none }
{code}

=> theme is completely broken as nuxeo_dm_default styling does not apply to the 
page

it should:
- take nuxeo_dm_default styling into account
- take nuxeo_dm_default2 styling into account after that (so that cascading 
ensures links are rendered with color red)

      was (Author: atchertchian):
    Fix registration of resources when order of registration is not the ideal 
one + better comments on generated css file:
http://hg.nuxeo.org/nuxeo/nuxeo-theme/rev/1245815e1af4

TODO: fix the fact that adding an additional style does not link it to the page
  
> Fix link between the page and it styling
> ----------------------------------------
>
>                 Key: NXP-7671
>                 URL: https://jira.nuxeo.com/browse/NXP-7671
>             Project: Nuxeo Enterprise Platform
>          Issue Type: Sub-task
>            Reporter: Anahide Tchertchian
>            Assignee: Jean-Marc Orliaguet
>
> The generated style name "nxtyle*" was not appearing on the body element => 
> the following changeset was done but it's really hacky so it should be 
> changed and made generic (see changes on class ThemeStylingServiceImpl.java): 
> http://hg.nuxeo.org/nuxeo/nuxeo-theme/rev/6eb2ba47aa50

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
ECM-tickets mailing list
[email protected]
http://lists.nuxeo.com/mailman/listinfo/ecm-tickets

Reply via email to