Chris Brannon wrote on Mon, Jul 10, 2017: > The inp_types list in decorate.c is also duplicated in html.c, and you > missed that one in the patch to add the new minor type. > Couldn't we just get rid of the inp_types from html.c and make inp_types > from decorate.c global?
I have done just that: removed inp_types in html.c and declared as extern in eb.h I think 'number' might also need to be moved to minor, but did not take the time to change that. > I'd also say that the function infShow needs to be reworked a little, so > that it shows the minor type, and not just text. > I'd like Karl's opinion on that. If he agrees, I wouldn't mind doing > that work after your patches are submitted. That would make sense to me, I have made both inp_types and inp_others global at the same time so you will be able to use it. > Aside from all of that, your patchset looks pretty good. > I still want Adam's opinion on the auth negotiation. I don't know if > his issue still exists, or whether it was subsequently fixed by libcurl > / other software. I have repushed the series without the last curl auth negotiation patch, so we are not held by that. The patch is still available in my master branch on github ( https://github.com/martinetd/edbrowse ) I have also added a first draft to the userguide, both in English and French, for the new command. We cannot change the command name once this is merged so now is a good time to complain about my naming sense! -- Dominique _______________________________________________ Edbrowse-dev mailing list [email protected] http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev
