Dominique Martinet <[email protected]> writes: > I have done just that: removed inp_types in html.c and declared as > extern in eb.h > I think 'number' might also need to be moved to minor, but did not take > the time to change that.
I think the itype_minor idea is a good one, because all these minor types are just text for the purposes of edbrowse. We can add new ones if we ever need to do that; they'll still be handled as text. The thing I'm a little concerned about is the loss of information. I didn't really think this through when I read your patches yesterday. When ipass is used successfully to edit a form field, its itype_minor automatically becomes INP_PW. That loses the old itype_minor. There may be cases where we need it, E.G., for the DOM. For instance, what if some JS code needs to find the fields having type "email"? This is a bit contrived. Perhaps we should add a "maskedText" flag to struct htmlTag, set that in ipass, and use it to determine whether or not to print the stars for masked fields? Or maybe my concern is overblown, I don't know. Sorry for being a harsh reviewer. I really do like your work, and I want to see it merged. -- Chris _______________________________________________ Edbrowse-dev mailing list [email protected] http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev
