Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: c267eb889fe1244840eb4fd067fe0d85e3cc271f
https://github.com/tianocore/edk2/commit/c267eb889fe1244840eb4fd067fe0d85e3cc271f
Author: Leif Lindholm <[email protected]>
Date: 2020-07-03 (Fri, 03 Jul 2020)
Changed paths:
M BaseTools/Scripts/PatchCheck.py
Log Message:
-----------
BaseTools/PatchCheck.py: add exception for diff orderfile
SetupGit.py adds BaseTools/Conf/diff.order as a diff orderfile, but that
file currently has CRLF line endings, which causes all pattern matches
to fail and the ordering remaining unaffected.
Add an exception to PatchCheck.py (to the existing .gitmodules clause),
so that we can merge the fix to the config file.
Cc: Bob Feng <[email protected]>
Cc: Liming Gao <[email protected]>
Signed-off-by: Leif Lindholm <[email protected]>
Reviewed-by: Bob Feng <[email protected]>
Commit: f56d52c7f581da4bb732ab6b456718ae59d39efa
https://github.com/tianocore/edk2/commit/f56d52c7f581da4bb732ab6b456718ae59d39efa
Author: Leif Lindholm <[email protected]>
Date: 2020-07-03 (Fri, 03 Jul 2020)
Changed paths:
M BaseTools/Scripts/PatchCheck.py
Log Message:
-----------
BaseTools: explicitly import email.header PatchCheck.py
On Debian 10 (Buster), when running PatchCheck.py with python2, a
backtrace is printed, starting from:
File "../edk2/BaseTools/Scripts/PatchCheck.py", line 595,
in find_patch_pieces
parts = email.header.decode_header(pmail.get('subject'))
AttributeError: 'module' object has no attribute 'header'
When using python3, this backtrace does not appear.
Explicitly importing email.header resolves this for python2 and does not
appear to cause any issues with python3.
Cc: Bob Feng <[email protected]>
Cc: Liming Gao <[email protected]>
Signed-off-by: Leif Lindholm <[email protected]>
Reviewed-by: Bob Feng <[email protected]>
Compare: https://github.com/tianocore/edk2/compare/0622a7b1b203...f56d52c7f581
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
