Branch: refs/heads/master
Home: https://github.com/tianocore/edk2
Commit: ff4c49a5ee38d613384fb2e318d891a800d32999
https://github.com/tianocore/edk2/commit/ff4c49a5ee38d613384fb2e318d891a800d32999
Author: Nate DeSimone <[email protected]>
Date: 2023-12-06 (Wed, 06 Dec 2023)
Changed paths:
M MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
Log Message:
-----------
MdeModulePkg/Bus: Fix XhciDxe Linker Issues
The DXE & MM standalone variant of AcpiTimerLib defines a global
named mPerformanceCounterFrequency. A global with an identical
name is also present in MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
Since XhciDxe has a dependency on TimerLib, this can cause link
errors due to the same symbol being defined twice if the platform
DSC chooses to use AcpiTimerLib as the TimerLib implementation for
any given platform.
To resolve this, I noted that some of the globals in Xhci.c are not
used outside of the Xhci.c compilation unit:
- mPerformanceCounterStartValue
- mPerformanceCounterEndValue
- mPerformanceCounterFrequency
- mPerformanceCounterValuesCached
I have changed the definition for all of these to static and added
an Xhci prefix. Since they are not used outside of the Xhci.c
compilation unit, there is no reason to have them exported as
globals.
Reviewed-by: Ray Ni <[email protected]>
Cc: Michael D Kinney <[email protected]>
Signed-off-by: Nate DeSimone <[email protected]>
_______________________________________________
edk2-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-commits
