Note: Cc: edk2-devel
Mike,
Can you *please* help out with this?? We've been discussing this since
April...
1. Why should we import all this code under the OVMF platform?
2. Why should we have a different license from the rest of EDK II if
this is all Intel code?
Last time we talked about this in early June, I thought you had a plan
for this. Any updates??
Thanks,
-Jordan
On 2015-07-24 16:00:23, Laszlo Ersek wrote:
> This mammoth DXE_SMM_DRIVER provides gEfiSmmConfigurationProtocolGuid
> (among many other things), which is a dependency of the SMM Initial
> Program Load module ("MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c"). It
> provides the mixed (assembly and C) language, lowest level SMM entry
> point.
>
> It is also responsible for populating the SMM_S3_RESUME_STATE object on
> normal boot that "OvmfPkg/SmmAccess/SmmAccessPei.c" sets aside in SMRAM
> and that "MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.c" uses on
> S3 resume.
>
> Quark_EDKII_v1.1.0/IA32FamilyCpuBasePkg can be found at
> <https://downloadcenter.intel.com/download/23197>, and comes under the
> 3-clause BSD License (which is allowed by OvmfPkg/Contributions.txt)
>
> We don't try to build the driver at the moment, just import it. The
> following patches will port it to, and slim it down for, OVMF.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <[email protected]>
> ---
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 156 ++
> OvmfPkg/QuarkPort/Include/AcpiCpuData.h | 53 +
> OvmfPkg/QuarkPort/Include/CpuHotPlugData.h | 52 +
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/CpuService.h | 213 +++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/SmmProfileArch.h | 116 ++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 782 +++++++++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/SmmFeatures.h | 191 +++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/SmmProfile.h | 83 +
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/SmmProfileInternal.h | 184 ++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/CpuS3.c | 454 +++++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/CpuService.c | 500 ++++++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 116 ++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/Semaphore.c | 78 +
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/SmmProfileArch.c | 84 +
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/MpService.c | 1813
> ++++++++++++++++++++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 1530
> +++++++++++++++++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/SmmFeatures.c | 380 ++++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/SmmProfile.c | 1376 +++++++++++++++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/SyncTimer.c | 130 ++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/MpFuncs.S | 186 ++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/MpFuncs.asm | 190 ++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/SmiEntry.S | 171 ++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/SmiEntry.asm | 176 ++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/SmiException.S | 1196 +++++++++++++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/SmiException.asm | 883 ++++++++++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/SmmInit.S | 122 ++
> OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/Ia32/SmmInit.asm | 132 ++
> 27 files changed, 11347 insertions(+)
>
> diff --git a/OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf
> b/OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf
> new file mode 100644
> index 0000000..b64db8f
> --- /dev/null
> +++ b/OvmfPkg/QuarkPort/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf
> @@ -0,0 +1,156 @@
> +## @file
> +#
> +# Agent Module to load other modules to deploy SMM Entry Vector for X86 CPU.
> +# Copyright (c) 2013-2015 Intel Corporation.
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions
> +# are met:
> +#
> +# * Redistributions of source code must retain the above copyright
> +# notice, this list of conditions and the following disclaimer.
> +# * Redistributions in binary form must reproduce the above copyright
> +# notice, this list of conditions and the following disclaimer in
> +# the documentation and/or other materials provided with the
> +# distribution.
> +# * Neither the name of Intel Corporation nor the names of its
> +# contributors may be used to endorse or promote products derived
> +# from this software without specific prior written permission.
> +#
> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> +#
> +#
> +##
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel