Hi David, > -----Original Message----- > From: David Woodhouse [mailto:dw...@infradead.org] > Sent: Thursday, August 6, 2015 8:11 PM > To: Zeng, Star; edk2-de...@ml01.01.org > Cc: Yao, Jiewen > Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support > > On Fri, 2015-07-31 at 20:22 +0800, Star Zeng wrote: > > This feature is added for UEFI spec that says > > "Stack may be marked as non-executable in identity mapped page tables". > > A PCD PcdSetNxForStack is added to turn on/off this feature, and it is > > FALSE by default. > > This broke the IA32 Ovmf build for me, with GCC 5.1.1 (Fedora 22): > > /home/dwmw2/git/edk2/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadF > unc.c:377:7: error: ‘PageTables’ may be used uninitialized in this function [- > Werror=maybe-uninitialized] > AsmWriteCr3 (PageTables); > ^ > /home/dwmw2/git/edk2/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadF > unc.c:224:9: note: ‘PageTables’ was declared here > UINTN PageTables; > ^ > cc1: all warnings being treated as errors > > > I think the warning is false, and you should probably file a GCC PR for > it as well as working around it in the source code.
I select to work around it in the source code. Patch has been sent out. Thanks for the report. > > -- > David Woodhouse Open Source Technology Centre > david.woodho...@intel.com Intel Corporation Thanks, Star _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
