On Tue, Aug 11, 2015 at 01:14:50PM +0200, Ard Biesheuvel wrote:
> Add one, remove two ...
> 
> After adding the CLANG35 toolchain yesterday, I noticed there is quite
> an abundance of toolchains supported in EDK2, and in the ARM case, there
> is some overlap between ARMGCC/ARMLINUXGCC and the GCC4x toolchains
> that are defined for all architectures.
> 
> Since the recent changes regarding the linker scripts and the GenFw
> changes to support relative AArch64 relocations, it is unsure whether
> these toolchains will still generate correct code. Instead of trying to
> find out, let's remove these altogether since the functionality they
> provide is also available via the GCC4x toolchains, which are kept in
> sync more closely with the other architectures they support.
> 
> The first five patches remove any references to ARMGCC and ARMLINUXGCC
> from various packages, and patch #6 removes them entirely from tools_def
> and build_rule.
> 
> Changes since v1:
> - added Daryl's ack to patch #1
> - removed the outdated ArmVExpressInstructions.txt rather than fixing up
>   its references to ARMGCC and ARMLINUXGCC (Leif)
> - instead of fixing the scripts and documentation under BeagleBoardPkg,
>   remove the need for a build script by adding the binary configuration
>   header to the FDF; that way we can remove the build scripts and docs
>   entirely (Leif)
>   
> Ard Biesheuvel (6):
>   StdLib: remove mention of ARMGCC
>   EmbeddedPkg: remove mention of ARMGCC
>   ArmPlatformPkg: remove mention of ARMGCC and ARMLINUXGCC
>   BeagleBoardPkg: fold configuration header into FD build
>   BeagleBoardPkg: remove outdated build scripts and instructions
>   BaseTools: remove ARMGCC and ARMLINUXGCC toolchains
> 
>  ArmPlatformPkg/ArmJunoPkg/Makefile                       |   4 +-
>  ArmPlatformPkg/Documentation/ArmVExpressInstructions.txt | 169 
> -----------------
>  ArmPlatformPkg/Scripts/Makefile                          |   4 +-
>  BaseTools/Conf/build_rule.template                       |  16 +-
>  BaseTools/Conf/tools_def.template                        | 200 
> --------------------
>  BeagleBoardPkg/BeagleBoardPkg.fdf                        |  13 +-
>  BeagleBoardPkg/ConfigurationHeader.bin                   | Bin 0 -> 512 bytes
>  BeagleBoardPkg/b.bat                                     |  68 -------
>  BeagleBoardPkg/ba.bat                                    |  68 -------
>  BeagleBoardPkg/build.sh                                  | 150 
> ---------------
>  BeagleBoardPkg/readme.txt                                |  78 --------
>  EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.c        |   4 +-
>  EmbeddedPkg/Library/GdbDebugAgent/gdbnotes.txt           |   2 +-
>  StdLib/StdLib.inc                                        |   2 -
>  14 files changed, 21 insertions(+), 757 deletions(-)
>  delete mode 100644 ArmPlatformPkg/Documentation/ArmVExpressInstructions.txt
>  create mode 100644 BeagleBoardPkg/ConfigurationHeader.bin
>  delete mode 100755 BeagleBoardPkg/b.bat
>  delete mode 100755 BeagleBoardPkg/ba.bat
>  delete mode 100755 BeagleBoardPkg/build.sh
>  delete mode 100644 BeagleBoardPkg/readme.txt
> 
> -- 
> 1.9.1

Good cleanup, and should avoid a lot of confusion long-term (whilst
potentially cause a little bit short-term).

For the series:
Reviewed-by: Leif Lindholm <[email protected]>

/
    Leif
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to