Reviewed-by: Daryl McDaniel <[email protected]>

>From a StdLib point-of-view, the patch to StdLib.inc looks fine.
I'll wait for approval of the other parts of the patch before committing
these changes.

Daryl


-----Original Message-----
From: edk2-devel [mailto:[email protected]] On Behalf Of Ard
Biesheuvel
Sent: Tuesday, August 11, 2015 4:15 AM
To: [email protected]; [email protected];
[email protected]
Cc: Jaben Carsey <[email protected]>; [email protected]; Daryl
McDaniel <[email protected]>; Ard Biesheuvel
<[email protected]>
Subject: [edk2] [PATCH v2 1/6] StdLib: remove mention of ARMGCC

The ARMGCC toolchain will be removed, and so will the build rule family by
the same name. So remove the BuildOptions specific to ARMGCC.

Cc: Daryl McDaniel <[email protected]>
Cc: Jaben Carsey <[email protected]>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <[email protected]>
Acked-by: Daryl McDaniel <[email protected]>
---
 StdLib/StdLib.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/StdLib/StdLib.inc b/StdLib/StdLib.inc index
9d540abd9221..fff9ef05e61f 100644
--- a/StdLib/StdLib.inc
+++ b/StdLib/StdLib.inc
@@ -122,7 +122,6 @@
    MSFT:*_*_IA32_CC_FLAGS   = /Od /D UEFI_C_SOURCE
     GCC:*_*_IA32_CC_FLAGS   = -O0 -DUEFI_C_SOURCE
     RVCT:*_*_*_CC_FLAGS     = --library_interface=none -DUEFI_C_SOURCE
-J$(WORKSPACE)/StdLib/Include -J$(WORKSPACE)/StdLib/Include/Arm
-  ARMGCC:*_*_*_CC_FLAGS     = -O0 -DUEFI_C_SOURCE -Wno-unknown-pragmas
-Wno-unused -Wno-format-zero-length
    XCODE:*_*_*_CC_FLAGS     = -O0 -DUEFI_C_SOURCE
-Wno-unused-const-variable -Wno-string-compare -Wno-sometimes-uninitialized
 
 !else
@@ -132,6 +131,5 @@
     MSFT:*_*_*_CC_FLAGS     = /X /Zc:wchar_t /D UEFI_C_SOURCE
      GCC:*_*_*_CC_FLAGS     = -nostdinc -nostdlib -DUEFI_C_SOURCE
     RVCT:*_*_*_CC_FLAGS     = --library_interface=none -DUEFI_C_SOURCE
-J$(WORKSPACE)/StdLib/Include -J$(WORKSPACE)/StdLib/Include/Arm
-  ARMGCC:*_*_*_CC_FLAGS     = -nostdinc -nostdlib -DUEFI_C_SOURCE
-Wno-unknown-pragmas -Wno-unused -Wno-format-zero-length
    XCODE:*_*_*_CC_FLAGS     = -nostdinc -nostdlib -DUEFI_C_SOURCE
-Wno-unused-const-variable -Wno-string-compare -Wno-sometimes-uninitialized
 !endif
--
1.9.1

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to