On Tue, 2015-08-25 at 14:45 -0700, Andrew Fish wrote: > Well the GOP returns a FrameBuffer, so that address needs to be > adjusted. So that seems to be the bug in the spec. I’ll bring this up > to the UEFI Forum. > > But I think for the non FrameBuffer case it would be better to fix > the drivers.
Another one is the UFS Host Controller protocol though it's local to EDK2 thankfully and not part of the spec. Here too, the protocol definition and underlying implementation rely on direct access. I understand the worry with letting direct access to BARs. The semantics and ordering especially can be very platform/architecture dependent. Memory barriers might be needed for accesses. It might make sense, if we provide a direct "map" API to define that it is weakly ordered and have an explicit barrier callback as well in there. Additionally it might make sense to also restrict it to prefetchable BARs. Cheers, Ben. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
