> On Aug 25, 2015, at 8:18 PM, Benjamin Herrenschmidt > <[email protected]> wrote: > > On Wed, 2015-08-26 at 01:53 +0000, Tian, Feng wrote: >> Hi, Ben & Andrew >> >> The GetBarAttributes() returns a set of ACPI 2.0 resource descriptors >> that describe the current configuration of the BARs of the PCI >> controller. >> >> What I understood is the returned value of GetBarAttributes() is a >> CPU address rather than a PCI address. From the view of PciIo, nobody >> needs to know/use Bar's PCI address. > > So that needs to be clarified in the spec (see the discussion on the > workgroup, some people seem to disagree :) >
It seems the ACPI spec is quite clear on the definition (UEFI Forum also owns the ACPI spec :)). It might be good to clarify? But we should discuss UEFI Forum stuff on that mailing list as it is not related to the open source project. > I'm happy with this approach however. It matches driver expectations > and doesn't require changing the APIs. > > It will require some churn inside PciBusDxe to make it cope with the > offsets but that's less of a problem as the overall APIs to drivers are > unaffected and thus it's just a matter of me doing it :) > Thanks, Andrew Fish > Cheers, > Ben. > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.01.org_mailman_listinfo_edk2-2Ddevel&d=BQICAg&c=eEvniauFctOgLOKGJOplqw&r=1HnUuXD1wDvw67rut5_idw&m=B_M5JYhsLK3VkzURWBjiFCMMT7-atKMChNG-Pub_BZQ&s=uqP460LXZNzdNQAmSrufFeY7oZXVsVH-oX7moNnl_S8&e= > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
