Hi Ard, I didn't send a Reviewed-by for the first 3 patches because they aren't in my area. But I read through them and they look good to me. If you feel a Reviewed-by is needed from me, I can give them a closer look.
Cheers, Ryan. On 26 August 2015 at 10:59, Ard Biesheuvel <[email protected]> wrote: > This series adds support for using the Intel BDS with ArmVExpress-FVP, > and for building it with UEFI Secure Boot enabled. > > Note that the former is a prerequisite of the latter, since the ARM BDS > has no GUI for enrolling certificates and enabling secure boot. > > Patch #1 removes the PlatformIntelBdsLIb dependency on BdsLib, which is > ARM BDS specific. (This patch has been sent out before as an RFC, and > reviewed by Laszlo, but I had to add a 'Status = EFI_SUCCESS;' to > GetConsoleDevicePathFromVariable () to fix a RELEASE build error, so > I dropped the R-b) > > Patch #2 fixes a bug in some debug code that clobbers a EFI_STATUS var > in the error path that is supposed to report it to the user. > > Patch #3 adds quiet boot/splash screen support to our PlatformIntelBdsLib > > Patch #4 enables the Intel BDS build of ArmVExpress-FVP, by introducing > a define 'USE_ARM_BDS' which defaults to TRUE but can be disabled on the > build command line to use the Intel BDS instead. > > Patch #5 enables the Secure Boot build of ArmVExpress-FVP, by introducing > a define 'SECURE_BOOT_ENABLE' which defaults to FALSE but can be enabled > on the build command line. > > Changes since v1: > - rebased onto FVP unification series > > Ard Biesheuvel (5): > ArmPlatformPkg/PlatformIntelBdsLib: remove ARM BDS dependency > ArmPlatformPkg/PlatformIntelBdsLib: fix error handling > ArmPlatformPkg/PlatformIntelBdsLib: add splash screen support > ArmPlatformPkg/ArmVExpressPkg: add support for the Intel BDS > ArmPlatformPkg/ArmVExpressPkg: enable UEFI Secure Boot > > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc | 18 > +++++++++ > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.fdf | 20 > ++++++++++ > ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 40 > ++++++++++++++++++++ > ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 36 > ++++++++++++------ > ArmPlatformPkg/Library/PlatformIntelBdsLib/IntelBdsPlatform.h | 1 - > ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 2 +- > 6 files changed, 104 insertions(+), 13 deletions(-) > > -- > 1.9.1 > > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
