[edk2] [MdeModulePkg] MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf will not compile with Xcode 6.3.2

[Andrew Fish]

"/usr/bin/clang" -target x86_64-pc-win32-macho -c -g -Os -Wall -Werror -Wextra 
-include AutoGen.h -funsigned-char -fno-ms-extensions -fno-stack-protector 
-fno-builtin -fshort-wchar -mno-implicit-float -mms-bitfields 
-Wno-unused-parameter -Wno-missing-braces -Wno-missing-field-initializers 
-Wno-tautological-compare -Wno-sign-compare 
-ftrap-function=undefined_behavior_has_been_optimized_away_by_clang  -o 
/Users/andrewfish/work/src/edk2/Build/MdeModule/DEBUG_XCODE5/X64/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe/OUTPUT/./Variable.obj
 -I/Users/andrewfish/work/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe 
-I/Users/andrewfish/work/src/edk2/Build/MdeModule/DEBUG_XCODE5/X64/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe/DEBUG
 -I/Users/andrewfish/work/src/edk2/MdePkg 
-I/Users/andrewfish/work/src/edk2/MdePkg/Include 
-I/Users/andrewfish/work/src/edk2/MdePkg/Include/X64 
-I/Users/andrewfish/work/src/edk2/MdeModulePkg 
-I/Users/andrewfish/work/src/edk2/MdeModu
 lePkg/Include 
/Users/andrewfish/work/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
/Users/andrewfish/work/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c:1713:8:
 error: array type 'VA_LIST' (aka '__builtin_va_list') is not assignable
  Args = Marker;
  ~~~~ ^

it is NOT portable C code to use = with markers, you need to use VA_COPY() 
defined in Base.h. 

This fixes the compiler warning with Xcode.

~/work/src/edk2(master)>git diff 
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c 
b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
index 31e1937..ef3dab3 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
@@ -1710,7 +1710,7 @@ CheckRemainingSpaceForConsistencyInternal (
   ASSERT_EFI_ERROR (Status);
 
   TotalNeededSize = 0;
-  Args = Marker;
+  VA_COPY (Args, Marker);
   VariableEntry = VA_ARG (Args, VARIABLE_ENTRY_CONSISTENCY *);
   while (VariableEntry != NULL) {
     //
@@ -1739,7 +1739,7 @@ CheckRemainingSpaceForConsistencyInternal (
     return FALSE;
   }
 
-  Args = Marker;
+  VA_COPY (Args, Marker);
   VariableEntry = VA_ARG (Args, VARIABLE_ENTRY_CONSISTENCY *);
   while (VariableEntry != NULL) {
     //


Contributed-under: TianoCore Contribution Agreement 1.0
Reviewed-by: Andrew Fish <af...@apple.com>

Thanks,

Andrew Fish
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel