> On Nov 6, 2015, at 1:51 AM, Zeng, Star <star.z...@intel.com> wrote:
>
> On 2015/10/23 14:04, Andrew Fish wrote:
>>
>>> On Oct 22, 2015, at 10:10 PM, Zeng, Star <star.z...@intel.com> wrote:
>>>
>>> On 2015/10/22 23:29, Andrew Fish wrote:
>>>>
>>>>> On Oct 21, 2015, at 6:34 PM, Zeng, Star <star.z...@intel.com> wrote:
>>>>>
>>>>> On 2015/10/22 7:02, Andrew Fish wrote:
>>>>>> "/usr/bin/clang" -target x86_64-pc-win32-macho -c -g -Os -Wall -Werror
>>>>>> -Wextra -include AutoGen.h -funsigned-char -fno-ms-extensions
>>>>>> -fno-stack-protector -fno-builtin -fshort-wchar -mno-implicit-float
>>>>>> -mms-bitfields -Wno-unused-parameter -Wno-missing-braces
>>>>>> -Wno-missing-field-initializers -Wno-tautological-compare
>>>>>> -Wno-sign-compare
>>>>>> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -o
>>>>>> /Users/andrewfish/work/src/edk2/Build/MdeModule/DEBUG_XCODE5/X64/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe/OUTPUT/./Variable.obj
>>>>>>
>>>>>> -I/Users/andrewfish/work/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe
>>>>>>
>>>>>> -I/Users/andrewfish/work/src/edk2/Build/MdeModule/DEBUG_XCODE5/X64/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe/DEBUG
>>>>>> -I/Users/andrewfish/work/src
>> /e
>>>> dk2
>>>>>> /MdePkg -I/Users/andrewfish/work/src/edk2/MdePkg/Include
>>>>>> -I/Users/andrewfish/work/src/edk2/MdePkg/Include/X64
>>>>>> -I/Users/andrewfish/work/src/edk2/MdeModulePkg
>>>>>> -I/Users/andrewfish/work/src/edk2/MdeModu
>>>>>> lePkg/Include
>>>>>> /Users/andrewfish/work/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>>>>>> /Users/andrewfish/work/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c:1713:8:
>>>>>> error: array type 'VA_LIST' (aka '__builtin_va_list') is not assignable
>>>>>> Args = Marker;
>>>>>> ~~~~ ^
>>>>>>
>>>>>> it is NOT portable C code to use = with markers, you need to use
>>>>>> VA_COPY() defined in Base.h.
>>>>>>
>>>>>> This fixes the compiler warning with Xcode.
>>>
>>> I met below commit failure when I try to help commit this patch.
>>>
>>> ERROR from SVN:
>>> A repository hook failed: MERGE request failed on
>>> '/p/edk2/code/trunk/edk2': Commit blocked by pre-commit hook (exit code 1)
>>> with output:
>>> The commit message format is not valid:
>>> * Line 3 of commit message is too long.
>>> * Line 4 of commit message is too long.
>>> https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
>>> <https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format>
>>>
>>> Could you update the commit log and commit the patch by yourself?
>>>
>>
>> Sorry I just put the diff in an email to discuss the issue. I will reformat
>> as a patch.
>
> Is there any following step for this contribution?
>
Star,
I'll send a set of patches soon for the clang build issues.
Thanks,
Andrew Fish
> Thanks,
> Star
>
>>
>> Thanks,
>>
>> Andrew Fish
>>
>>> Thanks,
>>> Star
>>>>>>
>>>>>> ~/work/src/edk2(master)>git diff
>>>>>> MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>>>>>> diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>>>>>> b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>>>>>> index 31e1937..ef3dab3 100644
>>>>>> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>>>>>> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
>>>>>> @@ -1710,7 +1710,7 @@ CheckRemainingSpaceForConsistencyInternal (
>>>>>> ASSERT_EFI_ERROR (Status);
>>>>>>
>>>>>> TotalNeededSize = 0;
>>>>>> - Args = Marker;
>>>>>> + VA_COPY (Args, Marker);
>>>>>> VariableEntry = VA_ARG (Args, VARIABLE_ENTRY_CONSISTENCY *);
>>>>>> while (VariableEntry != NULL) {
>>>>>> //
>>>>>> @@ -1739,7 +1739,7 @@ CheckRemainingSpaceForConsistencyInternal (
>>>>>> return FALSE;
>>>>>> }
>>>>>>
>>>>>> - Args = Marker;
>>>>>> + VA_COPY (Args, Marker);
>>>>>> VariableEntry = VA_ARG (Args, VARIABLE_ENTRY_CONSISTENCY *);
>>>>>> while (VariableEntry != NULL) {
>>>>>> //
>>>>>>
>>>>>>
>>>>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>>>>> Reviewed-by: Andrew Fish <af...@apple.com>
>>>>>
>>>>> Reviewed-by: Star Zeng <star.z...@intel.com>
>>>>>
>>>>> A little confusion that why there is no Signed-off-by for this
>>>>> contribution?
>>>>>
>>>>
>>>> Sorry did that backwards...
>>>>
>>>> Signed-off-by: Andrew Fish <af...@apple.com>
>>>>
>>>> Thanks,
>>>>
>>>> Andrew Fish
>>>>
>>>>> Thanks,
>>>>> Star
>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Andrew Fish
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> edk2-devel mailing list
>>>>> edk2-devel@lists.01.org
>>>>> https://lists.01.org/mailman/listinfo/edk2-devel
>>>
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org
>>> https://lists.01.org/mailman/listinfo/edk2-devel
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
