> -----Original Message----- > From: David Woodhouse [mailto:[email protected]] > Sent: Wednesday, November 25, 2015 4:40 PM > To: Long, Qin; Cohen, Eugene; Ard Biesheuvel; Leif Lindholm; Leif Lindholm > Cc: [email protected] > Subject: Re: [PATCH] CryptoPkg: Fix ARM RVCT 4 build > > On Wed, 2015-11-25 at 01:31 +0000, Long, Qin wrote: > > > > This patch looks a little complicated. I may need some times to > > evaluate it. > > > > One big changes may be the TS support part. We use our self-owned TS > > interface (leveraging the underlying ASN1 macro and PKCS7 routines) > > for UEFI timestamp support, instead of OpenSSL TS functions which > > cannot meet UEFI TS scenario. In theory, there should have no this > > kind of link issues (duplicated macro definitions) based on the > > current implementation. > > Hm, I must have missed that. What precisely do we need that the > upstream TS functions don't give us?
David, I cannot remember the details. The description may be wrong. One reason may be: we have to wrap our own ImageTimestampVerify() support because there are no formal TS support in early OpenSSL release. Let me check the history, and also check if the current TS function can work for UEFI scenario. :-) Best Regards & Thanks, LONG, Qin > > -- > David Woodhouse Open Source Technology Centre > [email protected] Intel Corporation _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
