Reviewed-by: Jaben Carsey <[email protected]>

> -----Original Message-----
> From: Ard Biesheuvel [mailto:[email protected]]
> Sent: Wednesday, December 02, 2015 9:03 AM
> To: [email protected]; [email protected]; Gao, Liming
> <[email protected]>; Zhang, Chao B <[email protected]>; Carsey,
> Jaben <[email protected]>; Qiu, Shumin <[email protected]>; Fan,
> Jeff <[email protected]>; Tian, Feng <[email protected]>
> Cc: Ard Biesheuvel <[email protected]>
> Subject: [PATCH 4/5] ShellPkg: add missing SHELL_STATUS cast
> Importance: High
> 
> The prototype of ShellCommandRunIfconfig() indicates that it returns
> a SHELL_STATUS, so returning a EFI_STATUS requires an explicit cast.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <[email protected]>
> ---
>  ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> index e16d46a8ec4d..2347aab9e96e 100644
> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
> @@ -1384,5 +1384,5 @@ ON_EXIT:
>      IfConfigCleanup (Private);
>    }
> 
> -  return Status;
> +  return (SHELL_STATUS)Status;
>  }
> --
> 1.9.1

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to